fix: tier 1 audit fixes — crashes, UI freezes, broken localization#589
Merged
fix: tier 1 audit fixes — crashes, UI freezes, broken localization#589
Conversation
…blocking runModal
…t:) across 50 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the highest-priority issues from the full codebase audit (AUDIT.md). Three independent fixes across 58 files:
ForEach crash prevention —
ForEach($array) { $item inon mutable struct arrays causes out-of-bounds crashes when items are removed. Replaced with ID-based safe binding lookup via newBinding+SafeLookupextension inConnectionSSHTunnelView,SSHProfileEditorView, andExportTableTreeView.Sheet presentation for prompts —
PasswordPromptHelperandPromptTOTPProviderusedrunModal()which freezes the entire app. Now usebeginSheetModal(for:)as sheets on the active window, withrunModal()fallback when no window is available.Localization fix — 112 instances of
String(localized: "text \(var)")across 50 files created dynamic keys that never match the strings catalog. All replaced withString(format: String(localized: "text %@"), var).Test plan
String(localized:interpolation violations